Add Toast Messages for Bad Logins by rosenjcb · Pull Request #1874 · LemmyNet/lemmy-ui
github.com
external-link
Description Right now if you try to login and you provide an unknown username/email or a wrong password, you will get no toast message. This PR adds toast messages for those scenarios and uses the ...

Let’s gooooooooo

@V4uban@lemmy.world
link
fedilink
English
41Y

Thank you!

(des)mosthenes
link
fedilink
English
81Y

yeeeeaaaaaaaa - see what you can do about hiding viewed content ^*

@rosenjcb@lemmy.world
creator
link
fedilink
English
31Y

Sounds like a cool feature. I’m honestly down for doing a good chunk of lemmy-ui dev work as I’m kind of getting rusty in React with my new job being strictly backend these days.

(des)mosthenes
link
fedilink
English
21Y

I might look into it myself, definitely curious but i’m always cautious with open source projects when committing a decently sized PR - yea that’s a great way to keep the knives sharp

@aaaantoine@lemmy.world
link
fedilink
English
11Y

If the size of the PR is a concern, maybe the maintainers will allow a staged approach. Create an Issue describing the feature and indicate step by step how you would implement. Then break the work into multiple pull requests.

If necessary, you could introduce a toggle that’s switched off by default until the feature is fully implemented.

(des)mosthenes
link
fedilink
English
21Y

ooooOO this is an interesting approach

@XTornado@lemmy.ml
link
fedilink
English
31Y

Yeah man… I am still waiting for that option that reddit has that hides any content you already upvoted/downvoted.

Create a post

This is a most excellent place for technology news and articles.


Our Rules


  1. Follow the lemmy.world rules.
  2. Only tech related content.
  3. Be excellent to each another!
  4. Mod approved content bots can post up to 10 articles per day.
  5. Threads asking for personal tech support may be deleted.
  6. Politics threads may be removed.
  7. No memes allowed as posts, OK to post as comments.
  8. Only approved bots from the list below, to ask if your bot can be added please contact us.
  9. Check for duplicates before posting, duplicates may be removed

Approved Bots


  • 1 user online
  • 220 users / day
  • 609 users / week
  • 1.39K users / month
  • 4.49K users / 6 months
  • 1 subscriber
  • 7.41K Posts
  • 84.7K Comments
  • Modlog